Open
Conversation
…rom the same CA sharing the same serial#.
Owner
|
Yeah it was still in the early stages of working in the certs. Thanks for the patches, much appreciated. I'll hopefully pull down the changes check them out and merge it in tonight. |
Author
|
Note that since I'm a n00b at git and I didn't realize new commits to my tree would end up in the same pull request, there's a 3d commit that adds a 5th parameter to createCert(). now the function sig looks like: dcrypt.x509.createCert(bitSize, days, serial, entries, extensions); (Apparently browsers hate seeing the same serial on certs signed by a common CA.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x509.createCert(bitSize, days, entries, extensions) now takes four arguments.
Sample usage:
The function returns an object with two members, "x509" for the certificate and "pkey" for the private key.
Note that createCert() will not automatically self-signed the certificate anymore. There's a new function for that:
x509.signCert(cert, ca_cert, ca_pkey) will sign a certificate.
To get the old self-signed behavior, use something like
Also, x509.parse() has a couple of fixes to prevent runaway strings from showing up in its output.